Reviewer's Guide

Adjusts the network dock applet layout to remove extra vertical spacing and relies on existing container margin handling, fixing incomplete display issues.

Sequence diagram for updated network applet layout handling

sequenceDiagram
    actor User
    participant Dock
    participant NetworkPlugin
    participant DockContentWidget

    User->>Dock: open network applet
    Dock->>NetworkPlugin: message(jsonMsg)
    NetworkPlugin->>NetworkPlugin: parse jsonMsg to msgObj
    alt msg type is APPLET_CONTAINER
        NetworkPlugin->>DockContentWidget: setMainLayoutMargins(QMargins(0, topMargin, 0, 0))
        DockContentWidget->>DockContentWidget: apply margins and spacing
    else other msg type
        NetworkPlugin->>NetworkPlugin: handle other message types
    end

Class diagram for updated DockContentWidget layout configuration

classDiagram
    class QWidget
    class DockContentWidget {
        - QVBoxLayout* m_mainLayout
        - QWidget* m_netView
        + DockContentWidget(QWidget* parent)
        + setMainLayoutMargins(QMargins margins)
    }

    DockContentWidget --|> QWidget

    class QVBoxLayout {
        + setContentsMargins(int left, int top, int right, int bottom)
        + setSpacing(int spacing)
        + addWidget(QWidget* widget, int stretch, Qt_Alignment alignment)
    }

    class QMargins {
        + QMargins(int left, int top, int right, int bottom)
    }

    class Qt_Alignment

    DockContentWidget --> QVBoxLayout : uses m_mainLayout
    DockContentWidget --> QWidget : uses m_netView

    %% Updated layout behavior
    DockContentWidget : m_mainLayout->setContentsMargins(0, 10, 0, 0)
    DockContentWidget : m_mainLayout->setSpacing(0)
    DockContentWidget : m_mainLayout->addWidget(m_netView, 0, Qt_AlignTop_AlignHCenter)
    DockContentWidget : m_mainLayout->addWidget(buttonWidget, 0, Qt_AlignBottom)

File-Level Changes

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment